Document timestamp input limits #8369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
alamb
reviewed
Nov 30, 2023
| @@ -157,6 +161,10 @@ pub fn to_timestamp_micros(args: &[ColumnarValue]) -> Result<ColumnarValue> { | |||
| } | |||
|
|
|||
| /// to_timestamp_nanos SQL function | |||
| /// | |||
| /// Note: `to_timestamp_nanos` returns `Timestamp(Nanosecond)`. The supported range for integer input is between `-9223372037` and `9223372036`. | |||
There was a problem hiding this comment.
this doesn't seem right. I think the argument is treated as nanoseconds, so the range is really -i64::MIN to i64::MAX
For example, this works just fine
❯ select to_timestamp_nanos(92233720360000)
;
+-------------------------------------------+
| to_timestamp_nanos(Int64(92233720360000)) |
+-------------------------------------------+
| 1970-01-02T01:37:13.720360 |
+-------------------------------------------+
1 row in set. Query took 0.000 seconds.
There was a problem hiding this comment.
yes, you are right
| @@ -1497,6 +1500,9 @@ return the corresponding timestamp. | |||
| to_timestamp_nanos(expression) | |||
| ``` | |||
|
|
|||
| Note: `to_timestamp_nanos` returns `Timestamp(Nanosecond)`. The supported range for integer input is between `-9223372037` and `9223372036`. | |||
alamb
approved these changes
Dec 1, 2023
Co-authored-by: Andrew Lamb <[email protected]>
|
🚀 |
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Dec 14, 2023
* document timestamp input limis * fix text * prettier * remove doc for nanoseconds * Update datafusion/physical-expr/src/datetime_expressions.rs Co-authored-by: Andrew Lamb <[email protected]> --------- Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8336
Closes #7958
Rationale for this change
Declared limits for
to_timestamp,to_timestamp_nanosfunctions to prevent overflows. Its been agreed in #8336 (comment) to useto_timestamp_secondsfunction for values between1677-09-21T00:12:44.0and2262-04-11T23:47:16.0What changes are included in this PR?
Are these changes tested?
No need
Are there any user-facing changes?
No