Add Library Guide for User Defined Functions: Window/Aggregate #8171
Conversation
Signed-off-by: veeupup <[email protected]>
Signed-off-by: veeupup <[email protected]>
Signed-off-by: veeupup <[email protected]>
|
Thanks for contributing more documentation @Veeupup |
There was a problem hiding this comment.
Thank you very much @Veeupup -- this is super helpful and a really nice PR 🙏 thank you for this (and all your other recent, high quality contributions ❤️ )
Something related to this that you might be interested in is #6747 (and I had a POC version of ithttps://github.com//pull/6746) to help make window functions more easily and ergonomically (creating Exprs programatically rather than via SQL).
| }) | ||
| } | ||
|
|
||
| // Optimization hint: this trait also supports `update_batch` and `merge_batch`, |
There was a problem hiding this comment.
this comment seems out of date as it is on merge_batch
|
While I am sure there are improvements we can make to this documentation, this is a lot better than we have now, so let's merge it in and iterate in subequent PRs. Thanks again @Veeupup |
Which issue does this PR close?
Closes #7307 .
Rationale for this change
What changes are included in this PR?
Add doc for user-defined window/aggregate function
Are these changes tested?
Are there any user-facing changes?