Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Fix temporary files created but not deleted during testing #8115

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

2010YOUY01
Copy link
Contributor

Which issue does this PR close?

NA

Rationale for this change

On the current main branch, some temporary testing files didn't get cleaned up after testing

> cargo test read_from_different_file_extension
> git status
Untracked files:
  (use "git add <file>..." to include in what will be committed)
        datafusion/core/output1.parquet
        datafusion/core/output2.parquet.snappy
        datafusion/core/output3.parquet.snappy.parquet

What changes are included in this PR?

Create those files under temporary directory, make sure they're cleaned up automatically afterwards

Are these changes tested?

No

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Nov 10, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed these files lately too -- thank you @2010YOUY01 for this cleanup!

@alamb alamb merged commit ceb09b2 into apache:main Nov 11, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants