Update arrow 49.0.0 and object_store 0.8.0 #8029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
tustvold
commented
Nov 2, 2023
datafusion/core/tests/fifo.rs
Outdated
| @@ -336,6 +336,7 @@ mod unix_test { | |||
|
|
|||
| /// It tests the INSERT INTO functionality. | |||
| #[tokio::test] | |||
| #[ignore] | |||
There was a problem hiding this comment.
#8021 shows how these tests might be ported
tustvold
changed the title
tustvold
force-pushed
the
prepare-object-store-0.8.0
branch
from
e60aa4d
to
d0875ce
Compare
This was referenced Nov 8, 2023
|
I believe this upgrade is blocked on sorting out how to upgrade the design to handle FIFO files as described in #8021 |
Technically speaking this bug was fixed by the update to 48.0.1 |
alamb
approved these changes
Nov 18, 2023
There was a problem hiding this comment.
Thank you @tustvold -- I know this was a long time in the making but the result is great.
I think this upgrade makes the code look much nicer (removing the double layer of errors from the object store APIs is quite nice 👨🍳 👌 )
| .await? | ||
| .try_collect() | ||
| .await?; | ||
| let entries: Vec<_> = self.store.list(Some(&self.path)).try_collect().await?; |
| @@ -680,7 +680,11 @@ mod tests { | |||
| // Ensure a useful error happens at plan time if invalid casts are used | |||
| let schema = Schema::new(vec![Field::new("a", DataType::Int32, false)]); | |||
|
|
|||
| let result = cast(col("a", &schema).unwrap(), &schema, DataType::LargeBinary); | |||
| let result = cast( | |||
There was a problem hiding this comment.
Is this change needed because arrow now supports casting Int32 --> LargeBinary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8092
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?