Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: update ci #7947

Closed
wants to merge 1 commit into from
Closed

Minor: update ci #7947

wants to merge 1 commit into from

Conversation

Weijun-H
Copy link
Member

@Weijun-H Weijun-H commented Oct 27, 2023

Which issue does this PR close?

Follow #7946

Rationale for this change

What changes are included in this PR?

Update the ci for example check

Are these changes tested?

Yes

Are there any user-facing changes?

@Weijun-H
Copy link
Member Author

Weijun-H commented Oct 27, 2023

Draft until #7946 be merged

@Weijun-H
Copy link
Member Author

Weijun-H commented Oct 27, 2023

The ci doesn't run all examples, should I add the missing one?

@Weijun-H Weijun-H marked this pull request as ready for review October 27, 2023 21:52
@Weijun-H Weijun-H force-pushed the update-ci branch 2 times, most recently from 0bad4e2 to 2692301 Compare October 27, 2023 22:53
@alamb
Copy link
Contributor

alamb commented Oct 30, 2023

Something doesn't seem right with this PR -- there is no change. Maybe the changes got list in the rebase. Marking as a draft. Thank you @Weijun-H

@alamb alamb marked this pull request as draft October 30, 2023 20:29
@Weijun-H
Copy link
Member Author

Something doesn't seem right with this PR -- there is no change. Maybe the changes got list in the rebase. Marking as a draft. Thank you @Weijun-H

Hi @alamb, because in #7946 we were able to run 'cargo run --example avro_sql' without '--features=datafusion/avro', I updated the CI to ensure they are the same.

@Weijun-H Weijun-H closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants