Support Decimal256 on AVG aggregate expression #7853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
Dandandan
approved these changes
Oct 18, 2023
alamb
approved these changes
Oct 18, 2023
| impl<T: DecimalType + ArrowNumericType> Debug for DecimalAvgAccumulator<T> { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| f.debug_struct("DecimalAvgAccumulator") | ||
| .field("sum", &self.sum) |
There was a problem hiding this comment.
is this needed because #derive doesn't know how to handle Option<T::Native>?
There was a problem hiding this comment.
Yea. #derive doesn't work.
|
Thank you @Dandandan @alamb |
jayzhan211
pushed a commit
to jayzhan211/datafusion
that referenced
this pull request
Oct 21, 2023
* More * More * More * More * Fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7852.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?