Add a test grouping on null (showing incorrect answers) #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
reviewed
Jul 27, 2021
| Ok(()) | ||
| } | ||
|
|
||
| #[tokio::test] |
Contributor
There was a problem hiding this comment.
We can also add it, but ignore the test?
Contributor
Author
There was a problem hiding this comment.
yeah, maybe that would be better...
If I am able to fix the problem in the next few days perhaps I can just incorporate this change into the proper fix 😆
I'll leave this PR as a draft for now
Contributor
Author
|
superceded by #793 |
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
* chore: bump DataFusion to rev c6f0d3c * fix style * Trigger Build * Update native/Cargo.toml --------- Co-authored-by: Andy Grove <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Re #782
Rationale for this change
I wrote this test while working on another issue and I felt it was good coverage to add. I can be convinced it is not a good idea, however
What changes are included in this PR?
A test (with incorrect answers) showing #782
Are there any user-facing changes?
No