-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose arrow-schema serde
crate feature flag
#7829
Conversation
Given this doesn't gate functionality in DataFusion, what is the motivation for plumbing it through, as opposed to down streams just declaring this? |
Datafusion reexports arrow crate but not reexports all arrow features, users need to add additional |
I'm not sure I would expect DataFusion to re-export the feature flags of arrow, but I'll defer to other maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @lewiszlw
The existing feature flags are documented here: https://github.com/apache/arrow-datafusion#crate-features
We currently do have a "simd" flag to enable an arrow feature flag. I think it would be ok to add a serde
feature as well
@lewiszlw could you please update the documentation with this new feature flag as well?
serde
crate feature flag
Sure, updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lewiszlw
Which issue does this PR close?
Expose serde feature
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?