Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose arrow-schema serde crate feature flag #7829

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

lewiszlw
Copy link
Member

Which issue does this PR close?

Expose serde feature

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Oct 16, 2023
@tustvold
Copy link
Contributor

Given this doesn't gate functionality in DataFusion, what is the motivation for plumbing it through, as opposed to down streams just declaring this?

@lewiszlw
Copy link
Member Author

lewiszlw commented Oct 16, 2023

Datafusion reexports arrow crate but not reexports all arrow features, users need to add additionalarrow-schema = { version = "46.0.0", features = ["serde"] } to enable serde feature. See https://github.com/roapi/roapi/blob/ea01ffe0d3978af0bb24065e711431bc52e6c96d/columnq/Cargo.toml#L16

@tustvold
Copy link
Contributor

I'm not sure I would expect DataFusion to re-export the feature flags of arrow, but I'll defer to other maintainers

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @lewiszlw

The existing feature flags are documented here: https://github.com/apache/arrow-datafusion#crate-features

We currently do have a "simd" flag to enable an arrow feature flag. I think it would be ok to add a serde feature as well

@lewiszlw could you please update the documentation with this new feature flag as well?

@alamb alamb changed the title Expose serde feature Expose arrow-schema serde crate feature flag Oct 16, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 16, 2023
@lewiszlw
Copy link
Member Author

Sure, updated.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lewiszlw

@alamb alamb merged commit 511be33 into apache:main Oct 17, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants