Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use code block for better formatting of rustdoc for PhysicalGroupBy #7823

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

qrilka
Copy link
Contributor

@qrilka qrilka commented Oct 14, 2023

Which issue does this PR close?

No particular issue, minor fixup

Rationale for this change

Code block looks bad in the crate rustdocs right now. Also text code block is used as advised by the rustdocs documentation (I see ignore blocks being used in unnest.rs)

What changes are included in this PR?

Improves rustdoc for PhysicalGroupBy

Are these changes tested?

with cargo test --doc

Are there any user-facing changes?

None

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @qrilka 🙏

@alamb alamb merged commit 8208ff0 into apache:main Oct 15, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants