Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Update LogicalPlan::join_on API, use it more #7814

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Minor: Update LogicalPlan::join_on API, use it more #7814

merged 2 commits into from
Oct 13, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 12, 2023

Which issue does this PR close?

Related to #7766, follow on to #7805

Rationale for this change

@jackwener suggested in https://github.com/apache/arrow-datafusion/pull/7805/files#r1356685435 that the newly added LogicalPlan::join_on API could be used more widely:

There are more code can be like this.

like join_on_false() .....

What changes are included in this PR?

  1. Use join_on more widely.
  2. Chang the API of LogicalPlan::join_on to match DataFrame::join_on and take an iterator of Exprs rather than just an Expr.

Are these changes tested?

Covered by existing tests

Are there any user-facing changes?

Since the API change in #7805 has not been released, this is not a end-user visible API change

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions optimizer Optimizer rules substrait labels Oct 12, 2023
jackwener
jackwener approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb

@alamb
Copy link
Contributor Author

alamb commented Oct 13, 2023

Thank you for the review @jackwener 🙏

@alamb alamb merged commit 05f0fa1 into apache:main Oct 13, 2023
22 checks passed
@alamb alamb deleted the alamb/join_on branch October 13, 2023 15:02
@matthewgapp matthewgapp mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackwener jackwener jackwener approved these changes

Assignees
No one assigned
Labels
logical-expr Logical plan and expressions optimizer Optimizer rules sql SQL Planner substrait
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alamb @jackwener