Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: coerce text to timestamps with timezones #7720

Merged
merged 2 commits into from
Oct 2, 2023
Merged

fix: coerce text to timestamps with timezones #7720

merged 2 commits into from
Oct 2, 2023

Commits on Oct 2, 2023

  1. fix: coerce text to timestamps with timezones 

    Extend the type coercion logic used with function calls to enable
text respresentaions of timestamps to be coerced to a timestamp
type with a timezone. If there is no other suitable choice the
timezone will be "+00" (UTC).

The specific use case for this change is to allow the third (offset)
parameter of the date_bin function to be specified as a constant
srting when the input array for the second parameter has a specitied
time zone.
    @mhilton
    mhilton committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    66a3b94 View commit details
    Browse the repository at this point in the history

  2. review comments 

    Create a named constant for the placeholder timezone as suggested
in the review.
    @mhilton
    mhilton committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    460635d View commit details
    Browse the repository at this point in the history