Fix bug in SimplifyExpressions
#7699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
changed the title
SimplifyExpressions (#214)
Dandandan
changed the title
SimplifyExpressions (#214)SimplifyExpressions
thinkharderdev
approved these changes
Sep 29, 2023
alamb
reviewed
Sep 29, 2023
| @@ -65,10 +65,13 @@ impl SimplifyExpressions { | |||
| ) -> Result<LogicalPlan> { | |||
| let schema = if !plan.inputs().is_empty() { | |||
| DFSchemaRef::new(merge_schema(plan.inputs())) | |||
| } else if let LogicalPlan::TableScan(_) = plan { | |||
| } else if let LogicalPlan::TableScan(scan) = plan { | |||
This was referenced Oct 5, 2023
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
Oct 7, 2023
Co-authored-by: Dan Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7700
Rationale for this change
Fix issue in
SimplifyExpressionsoptimizer which fails to simplify the TableScan filter expressions.This became visible in our testing after #7670 was merged.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?