Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create codeql.yml #7578

Closed
wants to merge 1 commit into from
Closed

Create codeql.yml #7578

wants to merge 1 commit into from

Conversation

jimexist
Copy link
Member

Which issue does this PR close?

Closes #.

Rationale for this change

so that we can get code scanned by GitHub for security issues

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

fail-fast: false
matrix:
language: [ 'python' ]
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby', 'swift' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# - https://gh.io/supported-runners-and-hardware-resources
# - https://gh.io/using-larger-runners
# Consider using larger runners for possible analysis time improvements.
runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This language doesn't look quite right to me -- I don't think we have any swift code in DataFusion

@alamb
Copy link
Contributor

alamb commented Sep 18, 2023

Thanks for the contributions @jimexist but I am not quite sure this is configuring CodeQL correctly

@jimexist
Copy link
Member Author

@alamb yes you are right - i only added this with autogenerated code. maybe we can close this.

@jimexist jimexist closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants