chore: add config option for allowing bounded use of sort-preserving operators #7164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
mustafasrepo
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Thanks @wolffcm, this PR is LGTM!. Having parametrize this is very nice.
|
Thanks @wolffcm and @mustafasrepo for the review! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7163.
Rationale for this change
This lets client code that uses bounded queries also make use of
SortPreservingRepartitionExec, which can be very helpful for removingSortExecnodes from plans.What changes are included in this PR?
This PR adds a new config option,
bounded_order_preserving_variantsto control whenSortPreservingRepartitionExecis produced.Are these changes tested?
Yes, I added a test that shows this option works as expected.
Are there any user-facing changes?
Yes, I updated the docs to include a description the new option.