replace once iter chain with array::IntoIter #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
approved these changes
Jul 11, 2021
Member
jorgecarleitao
left a comment
jorgecarleitao
left a comment
There was a problem hiding this comment.
This is a branch new rust's API, right? that we can now concert arrays to iterators of values.
Member
Author
|
@jorgecarleitao yes, this is a relatively new API that landed in stable rust 1.51. |
Member
|
can you remove the intoiter wrapping since array has it implemented by default? |
Member
Author
|
@jimexist good call, I was using 1.52 on my dev machine, which was giving me errors. |
alamb
pushed a commit
to alamb/datafusion
that referenced
this pull request
Jul 13, 2021
* replace once iter chain with array::IntoIter * use new array IntoIter implementation from rust 1.53
andygrove
pushed a commit
to andygrove/datafusion
that referenced
this pull request
Jan 31, 2025
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
H0TB0X420
pushed a commit
to H0TB0X420/datafusion
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follow up for #605.
What changes are included in this PR?
Replace manual once chain iterator with array::IntoIter to make code more readable based on feedback from #605 (comment).
Are there any user-facing changes?
no