Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: add sqllogictests for binary data type #6770

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 26, 2023

Which issue does this PR close?

Related to #6764

Rationale for this change

Some tests for #6767

What changes are included in this PR?

  1. Add binary.slt tests for Binary data type to add some end to end coverage
  2. Add note about using X' style strings to docs

Are these changes tested?

Yes, all tests

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jun 26, 2023
@tustvold tustvold changed the base branch from main to backup-main June 27, 2023 11:11
@tustvold tustvold changed the base branch from backup-main to main June 27, 2023 11:11
@alamb alamb marked this pull request as ready for review June 27, 2023 18:23
@alamb
Copy link
Contributor Author

alamb commented Jun 28, 2023

@ShiKaiWi and @jackwener -- I wonder if you have some time to review this PR?

Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb

@alamb alamb merged commit e91af99 into apache:main Jun 29, 2023
2010YOUY01 pushed a commit to 2010YOUY01/arrow-datafusion that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants