-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace supports_bounded_execution with supports_retract_batch #6695
Changes from all commits
d53d6c4
579b4d9
ce89853
2f9fc40
fbc978e
65d00e4
9a1bfa6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -155,8 +155,7 @@ impl WindowExpr for PlainAggregateWindowExpr { | |
} | ||
|
||
fn uses_bounded_memory(&self) -> bool { | ||
self.aggregate.supports_bounded_execution() | ||
&& !self.window_frame.end_bound.is_unbounded() | ||
!self.window_frame.end_bound.is_unbounded() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After thinking through this logic. Actually, as long as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This makes sense to me |
||
} | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,7 +69,7 @@ use std::ops::Range; | |
/// | ||
/// # Stateless `PartitionEvaluator` | ||
/// | ||
/// In this case, either [`Self::evaluate_all`] or [`Self::evaluate_with_rank_all`] is called with values for the | ||
/// In this case, either [`Self::evaluate_all`] or [`Self::evaluate_all_with_rank`] is called with values for the | ||
/// entire partition. | ||
/// | ||
/// # Stateful `PartitionEvaluator` | ||
|
@@ -221,7 +221,7 @@ pub trait PartitionEvaluator: Debug + Send { | |
)) | ||
} | ||
|
||
/// [`PartitionEvaluator::evaluate_with_rank_all`] is called for window | ||
/// [`PartitionEvaluator::evaluate_all_with_rank`] is called for window | ||
/// functions that only need the rank of a row within its window | ||
/// frame. | ||
/// | ||
|
@@ -248,7 +248,7 @@ pub trait PartitionEvaluator: Debug + Send { | |
/// (3,4), | ||
/// ] | ||
/// ``` | ||
fn evaluate_with_rank_all( | ||
fn evaluate_all_with_rank( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think, |
||
&self, | ||
_num_rows: usize, | ||
_ranks_in_partition: &[Range<usize>], | ||
|
@@ -278,7 +278,7 @@ pub trait PartitionEvaluator: Debug + Send { | |
|
||
/// Can this function be evaluated with (only) rank | ||
/// | ||
/// If `include_rank` is true, implement [`PartitionEvaluator::evaluate_with_rank_all`] | ||
/// If `include_rank` is true, implement [`PartitionEvaluator::evaluate_all_with_rank`] | ||
fn include_rank(&self) -> bool { | ||
false | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -139,8 +139,7 @@ impl WindowExpr for SlidingAggregateWindowExpr { | |
} | ||
|
||
fn uses_bounded_memory(&self) -> bool { | ||
self.aggregate.supports_bounded_execution() | ||
&& !self.window_frame.end_bound.is_unbounded() | ||
!self.window_frame.end_bound.is_unbounded() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to the case above. |
||
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THis is nice to have moved this logic entirely to the accumulator 👍