Minor: Move include_rank into BuiltInWindowFunctionExpr
#6620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustafasrepo
approved these changes
Jun 12, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #5781
Rationale for this change
BuiltInWindowFunctionExpralready contains several methods that describe how to call the correspondingPartitionEvaluatorsuch assupports_bounded_execution.The
include_rankfunction similarly controls how thePartitionEvaluatoris called, and therefore I think makes more sense to include onBuiltInWindowFunctionExpras wellAs we contemplate exposing
BuiltInWindowFunctionExprandPartitionEvaluatorto implement window functions, making sure the interface is consistent I think is valuableWhat changes are included in this PR?
include_rankintoBuiltInWindowFunctionExprAre these changes tested?
Covered by existing tests
Are there any user-facing changes?