Remove JIT based on cranelift, and jit feature

.github/workflows/docs_pr.yaml

@@ -49,6 +49,6 @@ jobs:
           rust-version: stable
       # Note: this does not include dictionary_expressions to reduce codegen
       - name: Run doctests
-        run: cargo test --doc --features avro,jit,scheduler,json
+        run: cargo test --doc --features avro,scheduler,json
       - name: Verify Working Directory Clean
         run: git diff --exit-code

.github/workflows/rust.yml

@@ -67,7 +67,7 @@ jobs:
 
       # Note: this does not include dictionary_expressions to reduce codegen
       - name: Check workspace with all features
-        run: cargo check --workspace --benches --features avro,jit,scheduler,json
+        run: cargo check --workspace --benches --features avro,scheduler,json
 
       - name: Check Cargo.lock for datafusion-cli
         run: |
@@ -97,7 +97,7 @@ jobs:
         with:
           rust-version: stable
       - name: Run tests (excluding doctests)
-        run: cargo test --lib --tests --bins --features avro,jit,scheduler,json,dictionary_expressions
+        run: cargo test --lib --tests --bins --features avro,scheduler,json,dictionary_expressions
       - name: Verify Working Directory Clean
         run: git diff --exit-code
 
@@ -153,7 +153,7 @@ jobs:
           rust-version: stable
       # Note: this does not include dictionary_expressions to reduce codegen
       - name: Run doctests
-        run: cargo test --doc --features avro,jit,scheduler,json
+        run: cargo test --doc --features avro,scheduler,json
       - name: Verify Working Directory Clean
         run: git diff --exit-code
 
@@ -272,7 +272,7 @@ jobs:
         shell: bash
         run: |
           export PATH=$PATH:$HOME/d/protoc/bin
-          cargo test --lib --tests --bins --features avro,jit,scheduler,json,dictionary_expressions
+          cargo test --lib --tests --bins --features avro,scheduler,json,dictionary_expressions
         env:
           # do not produce debug symbols to keep memory usage down
           RUSTFLAGS: "-C debuginfo=0"
@@ -305,7 +305,7 @@ jobs:
       - name: Run tests (excluding doctests)
         shell: bash
         run: |
-          cargo test --lib --tests --bins --features avro,jit,scheduler,json,dictionary_expressions
+          cargo test --lib --tests --bins --features avro,scheduler,json,dictionary_expressions
         env:
           # do not produce debug symbols to keep memory usage down
           RUSTFLAGS: "-C debuginfo=0"

Cargo.toml

@@ -22,7 +22,6 @@ members = [
     "datafusion/core",
     "datafusion/expr",
     "datafusion/execution",
-    "datafusion/jit",
     "datafusion/optimizer",
     "datafusion/physical-expr",
     "datafusion/proto",

ci/scripts/rust_clippy.sh

@@ -18,4 +18,4 @@
 # under the License.
 
 set -ex
-cargo clippy --all-targets --workspace --features avro,jit,pyarrow,scheduler -- -D warnings
+cargo clippy --all-targets --workspace --features avro,pyarrow,scheduler -- -D warnings

datafusion/common/Cargo.toml

@@ -35,7 +35,6 @@ path = "src/lib.rs"
 [features]
 avro = ["apache-avro"]
 default = []
-jit = ["cranelift-module"]
 pyarrow = ["pyo3", "arrow/pyarrow"]
 
 [dependencies]

datafusion/common/src/error.rs

@@ -28,8 +28,6 @@ use crate::{Column, DFSchema, OwnedTableReference};
 #[cfg(feature = "avro")]
 use apache_avro::Error as AvroError;
 use arrow::error::ArrowError;
-#[cfg(feature = "jit")]
-use cranelift_module::ModuleError;
 #[cfg(feature = "parquet")]
 use parquet::errors::ParquetError;
 use sqlparser::parser::ParserError;
@@ -85,9 +83,6 @@ pub enum DataFusionError {
     /// Errors originating from outside DataFusion's core codebase.
     /// For example, a custom S3Error from the crate datafusion-objectstore-s3
     External(GenericError),
-    #[cfg(feature = "jit")]
-    /// Error occurs during code generation
-    JITError(ModuleError),
     /// Error with additional context
     Context(String, Box<DataFusionError>),
     /// Errors originating from either mapping LogicalPlans to/from Substrait plans
@@ -281,13 +276,6 @@ impl From<ParserError> for DataFusionError {
     }
 }
 
-#[cfg(feature = "jit")]
-impl From<ModuleError> for DataFusionError {
-    fn from(e: ModuleError) -> Self {
-        DataFusionError::JITError(e)
-    }
-}
-
 impl From<GenericError> for DataFusionError {
     fn from(err: GenericError) -> Self {
         DataFusionError::External(err)
@@ -332,10 +320,6 @@ impl Display for DataFusionError {
             DataFusionError::External(ref desc) => {
                 write!(f, "External error: {desc}")
             }
-            #[cfg(feature = "jit")]
-            DataFusionError::JITError(ref desc) => {
-                write!(f, "JIT error: {desc}")
-            }
             #[cfg(feature = "object_store")]
             DataFusionError::ObjectStore(ref desc) => {
                 write!(f, "Object Store error: {desc}")
@@ -369,8 +353,6 @@ impl Error for DataFusionError {
             DataFusionError::Execution(_) => None,
             DataFusionError::ResourcesExhausted(_) => None,
             DataFusionError::External(e) => Some(e.as_ref()),
-            #[cfg(feature = "jit")]
-            DataFusionError::JITError(e) => Some(e),
             DataFusionError::Context(_, e) => Some(e.as_ref()),
             DataFusionError::Substrait(_) => None,
         }

datafusion/core/Cargo.toml

@@ -44,8 +44,6 @@ default = ["crypto_expressions", "regex_expressions", "unicode_expressions", "co
 dictionary_expressions = ["datafusion-physical-expr/dictionary_expressions", "datafusion-optimizer/dictionary_expressions"]
 # Used for testing ONLY: causes all values to hash to the same value (test for collisions)
 force_hash_collisions = []
-# Used to enable JIT code generation
-jit = ["datafusion-jit", "datafusion-row/jit"]
 pyarrow = ["datafusion-common/pyarrow"]
 regex_expressions = ["datafusion-physical-expr/regex_expressions", "datafusion-optimizer/regex_expressions"]
 # Used to enable scheduler
@@ -68,7 +66,6 @@ dashmap = "5.4.0"
 datafusion-common = { path = "../common", version = "23.0.0", features = ["parquet", "object_store"] }
 datafusion-execution = { path = "../execution", version = "23.0.0" }
 datafusion-expr = { path = "../expr", version = "23.0.0" }
-datafusion-jit = { path = "../jit", version = "23.0.0", optional = true }
 datafusion-optimizer = { path = "../optimizer", version = "23.0.0", default-features = false }
 datafusion-physical-expr = { path = "../physical-expr", version = "23.0.0", default-features = false }
 datafusion-row = { path = "../row", version = "23.0.0" }
@@ -159,11 +156,6 @@ required-features = ["scheduler"]
 harness = false
 name = "sql_planner"
 
-[[bench]]
-harness = false
-name = "jit"
-required-features = ["jit"]
-
 [[bench]]
 harness = false
 name = "sort"

datafusion/core/src/lib.rs

@@ -439,9 +439,6 @@ pub use datafusion_physical_expr as physical_expr;
 pub use datafusion_row as row;
 pub use datafusion_sql as sql;
 
-#[cfg(feature = "jit")]
-pub use datafusion_jit as jit;
-
 pub use common::from_slice;
 
 #[cfg(test)]