WIP use into iter to minimize array concats #579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
changed the title
jimexist
force-pushed
the
use-flat-map
branch
3 times, most recently
from
88d0f9f to
345879e
Compare
jimexist
commented
Jun 22, 2021
| .collect::<Result<Vec<_>>>()? | ||
| .into_iter() | ||
| .flatten(); | ||
| ScalarValue::iter_to_array(result) |
Member
Author
There was a problem hiding this comment.
@Dandandan i find that changing to use this, even if would be saving ArrayRef creating, makes the performance much worse, because it changes from iterating trusted len iterator to this boxed type with unbounded untrusted iterator.
added 5 commits
June 27, 2021 23:26
Member
Author
|
close due to performance concerns |
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Based on #565 so review that first
Closes #.
Rationale for this change
initial results show that this will regress the performance for small number of partitions
What changes are included in this PR?
Are there any user-facing changes?