Docs: Add logo back to sidebar #5688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Mar 22, 2023
|
|
||
|
|
||
| <a class="navbar-brand" href="{{ pathto(master_doc) }}"> | ||
| <img src="{{ pathto('_static/images/DataFusion-Logo-Background-White.png', 1) }}" class="logo" alt="logo"> |
Contributor
Author
There was a problem hiding this comment.
this used to be
<img src="{{ pathto('_static/images' + logo, 1) }}" class="logo" alt="logo">
But then sphinx complained that logo wasn't defined -- so I just hard coded it to match the main logo
jackwener
approved these changes
Mar 22, 2023
Contributor
Author
|
It is so cool it is already live on https://arrow.apache.org/datafusion/ ❤️
|
Contributor
|
Kinda stupid question... why logo is at the bottom? 🤔 |
Contributor
Author
TLDR is "I don't know" -- I was just putting it back where I found it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #5500
Rationale for this change
While working #5670 we lost the sidebar logo
What changes are included in this PR?
Add the logo back in
Are these changes tested?
Tested locally
Are there any user-facing changes?
docs