Skip to content

Wrong aggregation arguments error. #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 8 commits into from
Jun 8, 2021
Merged

Wrong aggregation arguments error. #505

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0595f54
Fix aggregate fn with invalid column
jgoday Jun 3, 2021
0bf891d
Fix error message
jgoday Jun 4, 2021
c1078ac
Fix error message
jgoday Jun 4, 2021
5b50308
fix clippy
jgoday Jun 4, 2021
80701f9
fix message and test
jgoday Jun 4, 2021
9db2e5f
avoid unwrap in test_aggregation_with_bad_arguments
jgoday Jun 4, 2021
bd5e062
Update datafusion/tests/sql.rs
jgoday Jun 6, 2021
a8f801a
Fix test_aggregation_with_bad_arguments
jgoday Jun 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion datafusion/src/physical_plan/aggregates.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,14 @@ pub fn create_aggregate_expr(
name: String,
) -> Result<Arc<dyn AggregateExpr>> {
// coerce
let arg = coerce(args, input_schema, &signature(fun))?[0].clone();
let arg = coerce(args, input_schema, &signature(fun))?;
if arg.is_empty() {
return Err(DataFusionError::Plan(format!(
"Aggregate error. Invalid or wrong number of arguments passed to aggregate: '{}'",
name,
)));
}
let arg = arg[0].clone();

let arg_types = args
.iter()
Expand Down