-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sqlparser-0.21] Rename function array
to make_array
#3199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
Core DataFusion crate
logical-expr
Logical plan and expressions
physical-expr
Physical Expressions
sql
SQL Planner
labels
Aug 18, 2022
2 tasks
tustvold
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me
alamb
pushed a commit
that referenced
this pull request
Aug 19, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (#3193) * Update planning for LIKE due to changes in sqlparser (#3194) * rename array function to make_array (#3199) * [sqlparser-0.21] Update trimExpr members during planning (#3181) * Update sqlparser version to use main from git * Update SqlExpr::Trim struct to match latest sqlparser changes * use sqlparser 0.21 (#3202) Co-authored-by: Ayush Dattagupta <[email protected]>
MazterQyou
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Dec 1, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193) * Update planning for LIKE due to changes in sqlparser (apache#3194) * rename array function to make_array (apache#3199) * [sqlparser-0.21] Update trimExpr members during planning (apache#3181) * Update sqlparser version to use main from git * Update SqlExpr::Trim struct to match latest sqlparser changes * use sqlparser 0.21 (apache#3202) Co-authored-by: Ayush Dattagupta <[email protected]>
MazterQyou
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Dec 1, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193) * Update planning for LIKE due to changes in sqlparser (apache#3194) * rename array function to make_array (apache#3199) * [sqlparser-0.21] Update trimExpr members during planning (apache#3181) * Update sqlparser version to use main from git * Update SqlExpr::Trim struct to match latest sqlparser changes * use sqlparser 0.21 (apache#3202) Co-authored-by: Ayush Dattagupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
core
Core DataFusion crate
logical-expr
Logical plan and expressions
physical-expr
Physical Expressions
sql
SQL Planner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3192
Subset of #3122
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?