Add SQL planner support for grouping() aggregate expressions
#2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
grouping() aggregate expressionsgrouping() aggregate expressions
alamb
approved these changes
May 10, 2022
There was a problem hiding this comment.
TIL "GROUPING" 🤯
https://www.postgresql.org/docs/9.5/functions-aggregate.html (Table 9-53. Grouping Operations) and https://docs.microsoft.com/en-us/sql/t-sql/functions/grouping-transact-sql?view=sql-server-ver15
| } | ||
|
|
||
| fn create_accumulator(&self) -> Result<Box<dyn Accumulator>> { | ||
| Err(DataFusionError::NotImplemented( |
There was a problem hiding this comment.
👍
I see -- I was going to suggest adding a test to sql_integ but it isn't ready yet 👍
I hadn't seen this before either, but it is used in the TPC-DS benchmarks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2477
Rationale for this change
Add support for planning SQL queries containing
grouping()aggregate expressionsWhat changes are included in this PR?
Add support for planning SQL queries containing
grouping()aggregate expressionsAre there any user-facing changes?
No