Use standard make_null_array for CASE #223
Merged
+2
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Build is failing due to apache/arrow-rs#238, which @ritchie46 has a PR up for 👍 |
Dandandan
approved these changes
Apr 29, 2021
Contributor
Dandandan
left a comment
Dandandan
left a comment
There was a problem hiding this comment.
😎 this will probably a bit faster as well (avoiding the builder)
returnString
approved these changes
Apr 29, 2021
jorgecarleitao
approved these changes
Apr 30, 2021
Member
jorgecarleitao
left a comment
jorgecarleitao
left a comment
There was a problem hiding this comment.
Great; much easier to read also. Thanks a lot, @alamb !
Contributor
Author
|
rebasing to pick up flatbuffers fix |
alamb
force-pushed
the
alamb/less_redundancy
branch
from
029ea7f to
cc7cd92
Compare
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
+ Coverage 76.43% 76.46% +0.02%
==========================================
Files 135 135
Lines 23264 23250 -14
==========================================
- Hits 17782 17777 -5
+ Misses 5482 5473 -9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #222
Shout out to @tustvold who noticed this first.
Rationale for this change
What changes are included in this PR?
Delete code and use arrow implementation
Are there any user-facing changes?
no