fix: Fix .gitignore in benchmarks/#21954
Merged
adriangb merged 1 commit intoapache:mainfrom Apr 30, 2026
Merged
Conversation
Contributor
|
Ty! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Reproducer
Under
benchmarks/, run./bench.sh run tpch, the generated result file won't get ignored by gitReason
A recent PR has changed one entry in
.gitignoreand caused the issuePR
This PR reverted this entry to the previous version.
Test: the above reproducer is working as expected after the change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?