Skip to content

writing table to parquet followed by read and schema check#21444

Merged
alamb merged 2 commits into
apache:mainfrom
Rich-T-kid:Richard/Dictionary-Encoding-Logic-Test
Apr 8, 2026
Merged

writing table to parquet followed by read and schema check#21444
alamb merged 2 commits into
apache:mainfrom
Rich-T-kid:Richard/Dictionary-Encoding-Logic-Test

Conversation

@Rich-T-kid
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

This attempts to bridge the missing test coverage mentioned by @alamb on this issue #8791

  • Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

The changes are test

Are there any user-facing changes?

no

Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @Rich-T-kid

@Rich-T-kid Rich-T-kid marked this pull request as ready for review April 7, 2026 18:52
@Rich-T-kid Rich-T-kid requested a review from alamb April 7, 2026 19:15
@alamb alamb added this pull request to the merge queue Apr 8, 2026
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Apr 8, 2026

Thanks @Rich-T-kid

Merged via the queue into apache:main with commit 5ba06ac Apr 8, 2026
31 checks passed
Rich-T-kid added a commit to Rich-T-kid/datafusion that referenced this pull request Apr 21, 2026
)

## Which issue does this PR close?
This attempts to bridge the missing test coverage mentioned by @alamb on
this issue apache#8791
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->

- Closes #.

## Rationale for this change

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

## What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

## Are these changes tested?
The changes are test
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

## Are there any user-facing changes?
no
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants