Skip to content

Fix serde of window lead/lag defaults#20608

Merged
avantgardnerio merged 1 commit intoapache:mainfrom
coralogix:fix/lead-lag-default-roundtrip
Feb 27, 2026
Merged

Fix serde of window lead/lag defaults#20608
avantgardnerio merged 1 commit intoapache:mainfrom
coralogix:fix/lead-lag-default-roundtrip

Conversation

@avantgardnerio
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Don't lose values in serde

What changes are included in this PR?

Preservation of window function arguments, particularly default value

Are these changes tested?

A RTT is included

Are there any user-facing changes?

Users with distributed query engines such as Ballista will have more queries work than before

note: AI was used to create this PR

@github-actions github-actions Bot added proto Related to proto crate physical-plan Changes to the physical-plan crate labels Feb 27, 2026
Copy link
Copy Markdown
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avantgardnerio avantgardnerio added this pull request to the merge queue Feb 27, 2026
Merged via the queue into apache:main with commit e567cb9 Feb 27, 2026
32 checks passed
@avantgardnerio avantgardnerio deleted the fix/lead-lag-default-roundtrip branch February 27, 2026 22:00
avantgardnerio added a commit to coralogix/arrow-datafusion that referenced this pull request Feb 27, 2026
avantgardnerio added a commit to coralogix/arrow-datafusion that referenced this pull request Mar 1, 2026
avantgardnerio added a commit to coralogix/arrow-datafusion that referenced this pull request Mar 2, 2026
avantgardnerio added a commit to coralogix/arrow-datafusion that referenced this pull request Mar 2, 2026
avantgardnerio added a commit to coralogix/arrow-datafusion that referenced this pull request Mar 2, 2026
avantgardnerio added a commit to coralogix/arrow-datafusion that referenced this pull request Mar 19, 2026
de-bgunter pushed a commit to de-bgunter/datafusion that referenced this pull request Mar 24, 2026
## Which issue does this PR close?

- Closes apache#20607.

## Rationale for this change

Don't lose values in serde

## What changes are included in this PR?

Preservation of window function arguments, particularly default value

## Are these changes tested?

A RTT is included

## Are there any user-facing changes?

Users with distributed query engines such as Ballista will have more
queries work than before

**note**: AI was used to create this PR
avantgardnerio added a commit to coralogix/arrow-datafusion that referenced this pull request Apr 8, 2026
avantgardnerio added a commit to coralogix/arrow-datafusion that referenced this pull request Apr 20, 2026
avantgardnerio added a commit to coralogix/arrow-datafusion that referenced this pull request Apr 30, 2026
avantgardnerio added a commit to coralogix/arrow-datafusion that referenced this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-plan Changes to the physical-plan crate proto Related to proto crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serde loses default value for window lead/lag

4 participants