Minor: Remove unneccessary vec! in SortMergeJoinStream initialization#18430
Merged
Jefffrey merged 1 commit intoapache:mainfrom Nov 2, 2025
Merged
Minor: Remove unneccessary vec! in SortMergeJoinStream initialization#18430Jefffrey merged 1 commit intoapache:mainfrom
Jefffrey merged 1 commit intoapache:mainfrom
Conversation
tschwarzinger
pushed a commit
to tschwarzinger/datafusion
that referenced
this pull request
Nov 2, 2025
…apache#18430) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> Remove a unnecessary vec allocation in SortMergeJoinStream initialization ## Rationale for this change Remove a unnecessary vec allocation in SortMergeJoinStream initialization ## What changes are included in this PR? Remove a unnecessary vec allocation in SortMergeJoinStream initialization ## Are these changes tested? Covered by existing ## Are there any user-facing changes? No
codetyri0n
pushed a commit
to codetyri0n/datafusion
that referenced
this pull request
Nov 11, 2025
…apache#18430) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> Remove a unnecessary vec allocation in SortMergeJoinStream initialization ## Rationale for this change Remove a unnecessary vec allocation in SortMergeJoinStream initialization ## What changes are included in this PR? Remove a unnecessary vec allocation in SortMergeJoinStream initialization ## Are these changes tested? Covered by existing ## Are there any user-facing changes? No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Remove a unnecessary vec allocation in SortMergeJoinStream initialization
Rationale for this change
Remove a unnecessary vec allocation in SortMergeJoinStream initialization
What changes are included in this PR?
Remove a unnecessary vec allocation in SortMergeJoinStream initialization
Are these changes tested?
Covered by existing
Are there any user-facing changes?
No