Skip to content

Conversation

@foskey51
Copy link
Contributor

Which issue does this PR close?

NA

Rationale for this change

I just noticed that an existing css was forcing extra padding in the navbar, which resulted in breaking the navbar ui in certain small screen (mobile) devices.

Old New (fixed)
Screenshot 2025-10-31 at 14-22-44 DataFrame API — Apache DataFusion documentation Screenshot 2025-10-31 at 14-23-19 DataFrame API — Apache DataFusion documentation

*notice how the right side navbar element is breaking out of the layout

To replicate this issue (firefox-browser) :

  • Open https://datafusion.apache.org/ in "responsive design mode" (ctrl+shift+m)
  • Select "Galaxy S20 Android 11" or "iPhone 12/13 + Pro iOS 14.6" ...etc device.

What changes are included in this PR?

Removed an existing css that was responsible for this behavior.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 31, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @foskey51 -- I tested this locally and it looks much better now

@Jefffrey Jefffrey added this pull request to the merge queue Nov 1, 2025
Merged via the queue into apache:main with commit a393fc7 Nov 1, 2025
5 checks passed
@Jefffrey
Copy link
Contributor

Jefffrey commented Nov 1, 2025

Thanks @foskey51

@foskey51 foskey51 deleted the fix/docs-mobile-navbar-padding branch November 1, 2025 02:54
tobixdev pushed a commit to tobixdev/datafusion that referenced this pull request Nov 2, 2025
## Which issue does this PR close?

NA

## Rationale for this change
I just noticed that an existing css was forcing extra padding in the
navbar, which resulted in breaking the navbar ui in certain small screen
(mobile) devices.

| Old | New (fixed) |
|:---:|:------------:|
| <img width="384" height="120" alt="Screenshot 2025-10-31 at 14-22-44
DataFrame API — Apache DataFusion documentation"
src="https://github.com/user-attachments/assets/c4e23471-cfde-4988-b887-13060da9faf1"
/> | <img width="384" height="117" alt="Screenshot 2025-10-31 at
14-23-19 DataFrame API — Apache DataFusion documentation"
src="https://github.com/user-attachments/assets/152c7b8d-cf0e-4a62-a616-264398d074a1"
/> |

*notice how the right side navbar element is breaking out of the layout

To replicate this issue  (firefox-browser) :
- Open https://datafusion.apache.org/ in "responsive design mode"
(ctrl+shift+m)
- Select "Galaxy S20 Android 11" or "iPhone 12/13 + Pro iOS 14.6" ...etc
device.

## What changes are included in this PR?
Removed an existing css that was responsible for this behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants