Move generate_series projection logic into LazyMemoryStream #18373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
mkleen
force-pushed
the
mkleen/move-projection-to-stream
branch
from
4cee5a0 to
a1f2b03
Compare
mkleen
force-pushed
the
mkleen/move-projection-to-stream
branch
from
a1f2b03 to
b3b3afe
Compare
mkleen
force-pushed
the
mkleen/move-projection-to-stream
branch
from
0f7b9b4 to
2c4b8d6
Compare
mkleen
force-pushed
the
mkleen/move-projection-to-stream
branch
from
2203bb4 to
acc8d54
Compare
alamb
approved these changes
Nov 3, 2025
jizezhang
pushed a commit
to jizezhang/datafusion
that referenced
this pull request
Nov 5, 2025
…8373) ## Which issue does this PR close? - None, This is a follow-up for apache#18298 ## Rationale for this change This moves the projection logic from `generate_series` out of the generator into `LazyMemoryStream` as discussed in apache#18298 (comment) This makes the projection logic generic for all generators. ## What changes are included in this PR? The projection logic is moved from `generate_series` into the `LazyMemoryStream` and relevant tests, where `LazyMemoryStream` is used, are adapted accordingly. ## Are these changes tested? This is only a small refactoring; the changes are covered by the tests from apache#18298 ## Are there any user-facing changes? There is a new parameter added to LazyMemoryExec::try_new method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This moves the projection logic from
generate_seriesout of the generator intoLazyMemoryStreamas discussed in #18298 (comment) This makes the projection logic generic for all generators.What changes are included in this PR?
The projection logic is moved from
generate_seriesinto theLazyMemoryStreamand relevant tests, whereLazyMemoryStreamis used, are adapted accordingly.Are these changes tested?
This is only a small refactoring; the changes are covered by the tests from #18298
Are there any user-facing changes?
There is a new parameter added to LazyMemoryExec::try_new method