Skip to content

Fix potential overflow when we print verbose physical plan #17798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 27, 2025
Merged

Fix potential overflow when we print verbose physical plan #17798

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7058717
change debug to trace for potential overflow
zhuqi-lucas Sep 26, 2025
d729d2b
fix comments.
zhuqi-lucas Sep 26, 2025
3194f66
fix
zhuqi-lucas Sep 26, 2025
6eaf64c
Merge branch 'main' into improve_potential_over_flow
zhuqi-lucas Sep 26, 2025
caacd4e
Merge branch 'main' into improve_potential_over_flow
zhuqi-lucas Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion datafusion/core/src/physical_planner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2135,7 +2135,15 @@ impl DefaultPhysicalPlanner {
"Optimized physical plan:\n{}\n",
displayable(new_plan.as_ref()).indent(false)
);
debug!("Detailed optimized physical plan:\n{new_plan:?}");

// Don't print new_plan directly, as that may overflow the stack.
// For example:
// thread 'tokio-runtime-worker' has overflowed its stack
// fatal runtime error: stack overflow, aborting
debug!(
"Detailed optimized physical plan:\n{}\n",
displayable(new_plan.as_ref()).indent(true)
);
Ok(new_plan)
}

Expand Down