refactor: use upstream arrow-rs inline_key_fast #17044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbutrovich
approved these changes
Aug 5, 2025
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
I love a good negative line count PR! Thanks for following this through to completion, @zhuqi-lucas!
Contributor
|
Thanks @zhuqi-lucas and @mbutrovich -- I am merging to keep the code flowing |
hknlof
pushed a commit
to hknlof/datafusion
that referenced
this pull request
Aug 20, 2025
LiaCastaneda
added a commit
to DataDog/datafusion
that referenced
this pull request
Sep 23, 2025
This reverts commit 71b92bc.
LiaCastaneda
added a commit
to DataDog/datafusion
that referenced
this pull request
Sep 30, 2025
This reverts commit 71b92bc.
LiaCastaneda
added a commit
to DataDog/datafusion
that referenced
this pull request
Sep 30, 2025
* Revert "Upgrade arrow/parquet to 56.0.0 (apache#16690)" This reverts commit fa1f8c1. * Revert "refactor: use upstream inline_key_fast (apache#17044)" This reverts commit 71b92bc. * Revert "fix: respect inexact flags in row group metadata (apache#16412)" This reverts commit afc90f7. * Revert "Test grouping by FixedSizeList (apache#17415)" This reverts commit 03f39e5. * Spelling (got reverted) * Also allow Byt from tests * Adjust sqllogictests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is the follow-up for #16630
We can use upstream inline_key_fast now since arrow-rs new release has the ability.
Rationale for this change
Change to use upstream inline_key_fast.
What changes are included in this PR?
Change to use upstream inline_key_fast.
Are these changes tested?
Yes, the upstream including the tests already.
Are there any user-facing changes?
No