Skip to content

Minor: Interval singleton #15859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2025
Merged

Minor: Interval singleton #15859

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e2357c
interval singleron
jayzhan211 Apr 25, 2025
132724d
fmt
jayzhan211 Apr 25, 2025
2a917d4
impl from
jayzhan211 Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions datafusion/expr-common/src/interval_arithmetic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,11 @@ impl Interval {
}
}

/// Create a new `Interval` with the same lower and upper bounds.
pub fn try_singleton(value: ScalarValue) -> Self {
Copy link
Contributor

@m09526 m09526 Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better name for this function would be just "singleton". Functions named try_* imply they are fallible and generally return a Result type.

Copy link
Contributor

@m09526 m09526 Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another idiomatic possibility would be to implement From<ScalarValue> for Interval.

Copy link
Contributor Author

@jayzhan211 jayzhan211 Apr 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another idiomatic possibility would be to implement From for Interval.

Sounds good!

Self::new(value.clone(), value)
}

/// Only for internal usage. Responsible for standardizing booleans and
/// floating-point values, as well as fixing NaNs. It doesn't validate
/// the given bounds for ordering, or verify that they have the same data
Expand Down
2 changes: 1 addition & 1 deletion datafusion/physical-expr/src/equivalence/properties/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1600,7 +1600,7 @@ fn get_expr_properties(
} else if let Some(literal) = expr.as_any().downcast_ref::<Literal>() {
Ok(ExprProperties {
sort_properties: SortProperties::Singleton,
range: Interval::try_new(literal.value().clone(), literal.value().clone())?,
range: Interval::try_singleton(literal.value().clone()),
preserves_lex_ordering: true,
})
} else {
Expand Down