fix: clickbench type err #15773
Merged
fix: clickbench type err #15773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weijun-H
approved these changes
Apr 20, 2025
Member
Weijun-H
left a comment
Weijun-H
left a comment
There was a problem hiding this comment.
Thanks @chenkovsky 👍 I tested cargo bench --profile=dev --bench sql_planner -- physical_plan_clickbench_all, and it worked perfectly.
| ELSE 0 | ||
| END > 1920 -- Extract and validate resolution parameter | ||
| AND levenshtein("UTMSource", "UTMCampaign") < 3 -- Verify UTM parameter similarity | ||
| AND levenshtein(CAST("UTMSource" AS STRING), CAST("UTMCampaign" AS STRING)) < 3 -- Verify UTM parameter similarity |
Member
There was a problem hiding this comment.
Suggested change
| AND levenshtein(CAST("UTMSource" AS STRING), CAST("UTMCampaign" AS STRING)) < 3 -- Verify UTM parameter similarity | |
| AND levenshtein('UTMSource', 'UTMCampaign') < 3 -- Verify UTM parameter similarity |
UPDATE:
ignore this suggection
Contributor
Author
There was a problem hiding this comment.
@Weijun-H Thank you. but I have a question. does single quotation mean literal string and double quotation mean column name? so CAST("UTMSource" AS STRING), and 'UTMSource' have different meaning?
Member
There was a problem hiding this comment.
Apologies, I misspoke earlier. In this case, we can’t use ‘UTMSource’ here because it’s a column name.
xudong963
approved these changes
Apr 21, 2025
Member
|
Thank you |
Contributor
|
Thank you so much @chenkovsky and @xudong963 |
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Cargo bench --bench sql_planneris failing #15753.Rationale for this change
column types of UTMSource and UTMCampaign in clickbench_partitioned are binary, but in datafusion/core/tests/data/clickbench_hits_10.parquet they are string.
What changes are included in this PR?
add a cast in sql
Are these changes tested?
Manually run clickbench
Are there any user-facing changes?
No