Skip to content

Improve simplify_expressions rule #15735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 3 commits into from
Apr 19, 2025
Merged

Improve simplify_expressions rule #15735

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fe7f93
Improve simplify_expressions rule
xudong963 Apr 16, 2025
101b80a
address comments
xudong963 Apr 17, 2025
074868d
address comments
xudong963 Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions datafusion/optimizer/src/simplify_expressions/simplify_exprs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,14 @@ impl SimplifyExpressions {
let name_preserver = NamePreserver::new(&plan);
let mut rewrite_expr = |expr: Expr| {
let name = name_preserver.save(&expr);
let original = expr.clone();
let expr = simplifier.simplify(expr)?;
// TODO it would be nice to have a way to know if the expression was simplified
// or not. For now conservatively return Transformed::yes
Ok(Transformed::yes(name.restore(expr)))
let transformed = if original == expr {
Transformed::no(original)
} else {
Transformed::yes(name.restore(expr))
};
Ok(transformed)
};

plan.map_expressions(|expr| {
Expand Down