Skip to content

Minor: remove unused logic for limit pushdown #15730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berkaysynnada merged 1 commit into from
Apr 21, 2025
Merged

Minor: remove unused logic for limit pushdown #15730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions datafusion/physical-optimizer/src/limit_pushdown.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,16 +246,7 @@ pub fn pushdown_limit_helper(
Ok((Transformed::no(pushdown_plan), global_state))
}
} else {
// Add fetch or a `LimitExec`:
// If the plan's children have limit and the child's limit < parent's limit, we shouldn't change the global state to true,
// because the children limit will be overridden if the global state is changed.
if !pushdown_plan
.children()
.iter()
.any(|&child| extract_limit(child).is_some())
{
global_state.satisfied = true;
}
global_state.satisfied = true;
pushdown_plan = if let Some(plan_with_fetch) = maybe_fetchable {
if global_skip > 0 {
add_global_limit(plan_with_fetch, global_skip, Some(global_fetch))
Expand Down