Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Apr 9, 2025

Which issue does this PR close?

Rationale for this change

With short circuiting in expressions from @acking-you in #15462, DataFusion now successfully runs some queries that it used to fail on

@Omega359 verified that Postgres and DuckDB also successfully complete these queries:

He also updated the expected results in

What changes are included in this PR?

Update datafusion main to use the updated expected results

Are these changes tested?

I tried to run the extended suite on this PR here: https://github.com/apache/datafusion/pull/15655/checks?check_run_id=40243127451 but that doesn't seem to be working

I tested them manually locally using

INCLUDE_SQLITE=true cargo test --profile release-nonlto --test sqllogictests

Results were:

     Running bin/sqllogictests.rs (target/release-nonlto/deps/sqllogictests-96dbbc528a70898f)
Completed 708 test files in 6 minutes
andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$

Are there any user-facing changes?

@alamb alamb marked this pull request as draft April 9, 2025 10:47
@alamb
Copy link
Contributor Author

alamb commented Apr 9, 2025

Run extended tests

Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alamb
Copy link
Contributor Author

alamb commented Apr 9, 2025

Thanks @phillipleblanc and @xudong963

@alamb alamb merged commit 7ef5c4b into apache:main Apr 9, 2025
31 of 32 checks passed
@alamb alamb deleted the alamb/fix_extended_test branch April 9, 2025 14:59
nirnayroy pushed a commit to nirnayroy/datafusion that referenced this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

extended tests failing on main (External error: query is expected to fail, but actually succeed:)

3 participants