replace TypeSignature::String with TypeSignature::Coercible for trim functions #14865
+71
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Member
Author
|
I think this PR is ready for review now. cc: @jayzhan211 |
jayzhan211
reviewed
Feb 26, 2025
| fn btrim<T: OffsetSizeTrait>(args: &[ArrayRef]) -> Result<ArrayRef> { | ||
| let use_string_view = args[0].data_type() == &DataType::Utf8View; | ||
| general_trim::<T>(args, TrimType::Both, use_string_view) | ||
| let args = if args.len() > 1 { |
Contributor
There was a problem hiding this comment.
casting logic should be in invoke_with_args to keep this kernel function easy to be reuse
Contributor
There was a problem hiding this comment.
Now, I think this is fine for private function.
I think we also need to change starts_with to private function in https://github.com/apache/datafusion/pull/14812/files. I don't know why it is public but it shouldn't
jayzhan211
approved these changes
Feb 26, 2025
Contributor
|
Thanks @zjregee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
TypeSignature::StringwithTypeSignature::Coercible#14759.Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
None.