Skip to content

Conversation

@Ted-Jiang
Copy link
Member

Which issue does this PR close?

#1462

Closes #.

@Dandandan
Copy link
Contributor

@Ted-Jiang great find/fix! there is one clippy error:

   --> datafusion/src/physical_plan/repartition.rs:581:24
    |
581 |             .map(|x| x.into_iter().map(|x| x.num_rows()).sum::<usize>())
    |                        ^^^^^^^^^ help: call directly: `iter`
    |
    = note: `-D clippy::into-iter-on-ref` implied by `-D warnings`

@Ted-Jiang
Copy link
Member Author

@Ted-Jiang great find/fix! there is one clippy error:

   --> datafusion/src/physical_plan/repartition.rs:581:24
    |
581 |             .map(|x| x.into_iter().map(|x| x.num_rows()).sum::<usize>())
    |                        ^^^^^^^^^ help: call directly: `iter`
    |
    = note: `-D clippy::into-iter-on-ref` implied by `-D warnings`

Thanks, how do i check this before commit ? i can not find in Developer's guide 😂

@Dandandan
Copy link
Contributor

@Ted-Jiang great find/fix! there is one clippy error:

   --> datafusion/src/physical_plan/repartition.rs:581:24
    |
581 |             .map(|x| x.into_iter().map(|x| x.num_rows()).sum::<usize>())
    |                        ^^^^^^^^^ help: call directly: `iter`
    |
    = note: `-D clippy::into-iter-on-ref` implied by `-D warnings`

Thanks, how do i check this before commit ? i can not find in Developer's guide 😂

You can run cargo clippy

@Ted-Jiang great find/fix! there is one clippy error:

   --> datafusion/src/physical_plan/repartition.rs:581:24
    |
581 |             .map(|x| x.into_iter().map(|x| x.num_rows()).sum::<usize>())
    |                        ^^^^^^^^^ help: call directly: `iter`
    |
    = note: `-D clippy::into-iter-on-ref` implied by `-D warnings`

Thanks, how do i check this before commit ? i can not find in Developer's guide 😂

You can run cargo clippy and you get the warnings 👍

@Dandandan Dandandan merged commit 35d65fc into apache:master Dec 18, 2021
@Dandandan
Copy link
Contributor

Thank you @Ted-Jiang

@houqp houqp added the bug Something isn't working label Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants