refactor: remove uses of arrow_buffer & arrow_array and use reexport in arrow instead
#14503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
approved these changes
Feb 5, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you so much @Chen-Yuan-Lai
I also took the liberty of removing a few more uses of arrow_buffer and removed it from the Cargo.toml files and pushed that change to this PR
It turns out OffsetBufferBuilder is still used in some places so I made an upstream PR in arrow-rs to help:
Any chance you are willing to do the same thing for arrow-array?
alamb
reviewed
Feb 5, 2025
| ], optional = true } | ||
| arrow = { workspace = true } | ||
| arrow-array = { workspace = true } | ||
| arrow-buffer = { workspace = true } |
Contributor
There was a problem hiding this comment.
I also removed the dependency directly from Cargo.toml
Contributor
Author
Sure : ) |
Contributor
To be clear, I suggest we do this in a separate PR |
Contributor
|
I plan to merge this PR when the CI checks pass |
Contributor
|
Thanks again @Chen-Yuan-Lai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #14115.
Rationale for this change
As #14115 (comment) says, we should use reexport in arrow as much as possible.
What changes are included in this PR?
Are these changes tested?
use arrow_buffer:: xxx->use arrow::buffer::xxxuse arrow_array:: xxx->use arrow::array::xxxI leave some imports as it is when those modules weren't reexported in arrow
Are there any user-facing changes?