Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion datafusion/expr/src/logical_plan/plan.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1497,7 +1497,9 @@ impl LogicalPlan {
(_, Some(dt)) => {
param_types.insert(id.clone(), Some(dt.clone()));
}
_ => {}
_ => {
param_types.insert(id.clone(), None);
}
}
}
Ok(TreeNodeRecursion::Continue)
Expand Down Expand Up @@ -4347,4 +4349,25 @@ digraph {
plan.rewrite_with_subqueries(&mut rewriter).unwrap();
assert!(!rewriter.filter_found);
}

#[test]
fn test_with_unresolved_placeholders() {
let field_name = "id";
let placeholder_value = "$1";
let schema = Schema::new(vec![Field::new(field_name, DataType::Int32, false)]);

let plan = table_scan(TableReference::none(), &schema, None)
.unwrap()
.filter(col(field_name).eq(placeholder(placeholder_value)))
.unwrap()
.build()
.unwrap();

// Check that the placeholder parameters have not received a DataType.
let params = plan.get_parameter_types().unwrap();
assert_eq!(params.len(), 1);

let parameter_type = params.clone().get(placeholder_value).unwrap().clone();
assert_eq!(parameter_type, None);
}
}
Loading