Minimize features #1399
Merged
Minimize features #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
requested changes
Dec 4, 2021
|
|
||
| [dependencies] | ||
| ahash = "0.7" | ||
| ahash = { version = "0.7", default-features = false } |
Contributor
There was a problem hiding this comment.
At least hashbrown also depends on ahash by default.
So shouldn't we make that feature in hashbrown optional too?
Contributor
Author
There was a problem hiding this comment.
hashbrown sets default-features = false for ahash. https://github.com/rust-lang/hashbrown/blob/b3eaf32e608d1ec4c10963a4f495503d7f8a7ef5/Cargo.toml#L16
houqp
approved these changes
Dec 10, 2021
The default feature set of the ahash crate is ["std"][1]. The std feature enables features which require the standard library, namely `AHashMap` and `AHashSet`. DataFusion currently only uses `AHasher`, `CallHasher`, and `RandomState`, none of which require the standard library. This gives more control to projects depending on datafusion to minimize the amount of code they depend on. [1]: https://github.com/tkaitchuck/aHash/blob/e77cab8c1e15bfc9f54dfd28bd8820c2a7bb27c4/Cargo.toml#L24-L25
In fact, the "oldtime" feature is [considered deprecated][1] and only included by default for backwards compatibility. The other features don't appear to be used by datafusion or ballista, so this gives projects depending on these crates more flexibility in what they choose to include. [1]: https://github.com/chronotope/chrono/blame/f6bd567bb677262645c1fc3131c8c1071cd77ec3/README.md#L88-L94
carols10cents
force-pushed
the
minimize-features
branch
from
ee2b9c3 to
dafabde
Compare
Dandandan
approved these changes
Dec 18, 2021
Contributor
Dandandan
left a comment
Dandandan
left a comment
There was a problem hiding this comment.
Thanks @carols10cents !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1398.
Rationale for this change
Give projects depending on datafusion more choice in what features to enable.
What changes are included in this PR?
Disabling default features for chrono and ahash in datafusion and ballista.
Are there any user-facing changes?
If projects depending on datafusion/ballista are making use of the coincidence that they turn on chrono or ahash features, this might mean they have to turn on the features themselves, but that would be a bug in that project's use of the crates.