Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions datafusion/src/physical_plan/projection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ use super::expressions::Column;
use super::metrics::{BaselineMetrics, ExecutionPlanMetricsSet, MetricsSet};
use super::{RecordBatchStream, SendableRecordBatchStream, Statistics};
use async_trait::async_trait;

use futures::stream::Stream;
use futures::stream::StreamExt;

Expand All @@ -62,18 +61,21 @@ impl ProjectionExec {
) -> Result<Self> {
let input_schema = input.schema();

let fields: Result<Vec<_>> = expr
let fields: Vec<Field> = expr
.iter()
.map(|(e, name)| {
Ok(Field::new(
name,
e.data_type(&input_schema)?,
e.nullable(&input_schema)?,
))
match input_schema.field_with_name(&name) {
Ok(f) => f.clone(),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think this will get the field level metadata

However, I think there is also Schema level metadata that still will not get copied over.

In order to copy that metadata, you can call Schema::new_with_metadata below rather than Schema::new()

https://docs.rs/arrow/6.3.0/arrow/datatypes/struct.Schema.html#method.new_with_metadata

Err(_) => Field::new(
name,
e.data_type(&input_schema).unwrap(),
e.nullable(&input_schema).unwrap_or(true),
)
}
})
.collect();

let schema = Arc::new(Schema::new(fields?));
let schema = Arc::new(Schema::new(fields));

Ok(Self {
expr,
Expand Down Expand Up @@ -178,7 +180,7 @@ impl ExecutionPlan for ProjectionExec {

fn stats_projection(
stats: Statistics,
exprs: impl Iterator<Item = Arc<dyn PhysicalExpr>>,
exprs: impl Iterator<Item=Arc<dyn PhysicalExpr>>,
) -> Statistics {
let column_statistics = stats.column_statistics.map(|input_col_stats| {
exprs
Expand Down Expand Up @@ -296,6 +298,11 @@ mod tests {
Arc::new(csv),
)?;

let col_field = projection.schema.field(0);
let col_metadata = col_field.metadata().clone().unwrap().clone();
let data: &str = &col_metadata["testing"];
assert_eq!(data, "test");

let mut partition_count = 0;
let mut row_count = 0;
for partition in 0..projection.output_partitioning().partition_count() {
Expand Down
11 changes: 8 additions & 3 deletions datafusion/src/test_util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
//! Utility functions to make testing DataFusion based crates easier

use std::{env, error::Error, path::PathBuf, sync::Arc};
use std::collections::BTreeMap;

use arrow::datatypes::{DataType, Field, Schema, SchemaRef};

Expand Down Expand Up @@ -229,8 +230,10 @@ fn get_data_dir(udf_env: &str, submodule_data: &str) -> Result<PathBuf, Box<dyn

/// Get the schema for the aggregate_test_* csv files
pub fn aggr_test_schema() -> SchemaRef {
Arc::new(Schema::new(vec![
Field::new("c1", DataType::Utf8, false),
let mut f1 = Field::new("c1", DataType::Utf8, false);
f1.set_metadata(Some(BTreeMap::from_iter(vec![("testing".into(), "test".into())].into_iter())));
let schema = Schema::new(vec![
f1,
Field::new("c2", DataType::UInt32, false),
Field::new("c3", DataType::Int8, false),
Field::new("c4", DataType::Int16, false),
Expand All @@ -243,7 +246,9 @@ pub fn aggr_test_schema() -> SchemaRef {
Field::new("c11", DataType::Float32, false),
Field::new("c12", DataType::Float64, false),
Field::new("c13", DataType::Utf8, false),
]))
]);

Arc::new(schema)
}

#[cfg(test)]
Expand Down