Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions datafusion/src/physical_plan/projection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ use super::expressions::Column;
use super::metrics::{BaselineMetrics, ExecutionPlanMetricsSet, MetricsSet};
use super::{RecordBatchStream, SendableRecordBatchStream, Statistics};
use async_trait::async_trait;

use futures::stream::Stream;
use futures::stream::StreamExt;

Expand All @@ -62,18 +61,22 @@ impl ProjectionExec {
) -> Result<Self> {
let input_schema = input.schema();

let fields: Result<Vec<_>> = expr
let fields: Vec<Field> = expr
.iter()
.map(|(e, name)| {
Ok(Field::new(
.map(|(e, name)| match input_schema.field_with_name(&name) {
Ok(f) => f.clone(),
Err(_) => Field::new(
name,
e.data_type(&input_schema)?,
e.nullable(&input_schema)?,
))
e.data_type(&input_schema).unwrap(),
e.nullable(&input_schema).unwrap_or(true),
),
})
.collect();

let schema = Arc::new(Schema::new(fields?));
let schema = Arc::new(Schema::new_with_metadata(
fields,
input_schema.metadata().clone(),
));

Ok(Self {
expr,
Expand Down Expand Up @@ -296,6 +299,11 @@ mod tests {
Arc::new(csv),
)?;

let col_field = projection.schema.field(0);
let col_metadata = col_field.metadata().clone().unwrap().clone();
let data: &str = &col_metadata["testing"];
assert_eq!(data, "test");

let mut partition_count = 0;
let mut row_count = 0;
for partition in 0..projection.output_partitioning().partition_count() {
Expand Down
13 changes: 10 additions & 3 deletions datafusion/src/test_util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

//! Utility functions to make testing DataFusion based crates easier

use std::collections::BTreeMap;
use std::{env, error::Error, path::PathBuf, sync::Arc};

use arrow::datatypes::{DataType, Field, Schema, SchemaRef};
Expand Down Expand Up @@ -229,8 +230,12 @@ fn get_data_dir(udf_env: &str, submodule_data: &str) -> Result<PathBuf, Box<dyn

/// Get the schema for the aggregate_test_* csv files
pub fn aggr_test_schema() -> SchemaRef {
Arc::new(Schema::new(vec![
Field::new("c1", DataType::Utf8, false),
let mut f1 = Field::new("c1", DataType::Utf8, false);
f1.set_metadata(Some(BTreeMap::from_iter(
vec![("testing".into(), "test".into())].into_iter(),
)));
let schema = Schema::new(vec![
f1,
Field::new("c2", DataType::UInt32, false),
Field::new("c3", DataType::Int8, false),
Field::new("c4", DataType::Int16, false),
Expand All @@ -243,7 +248,9 @@ pub fn aggr_test_schema() -> SchemaRef {
Field::new("c11", DataType::Float32, false),
Field::new("c12", DataType::Float64, false),
Field::new("c13", DataType::Utf8, false),
]))
]);

Arc::new(schema)
}

#[cfg(test)]
Expand Down