Backport "Provide field and schema metadata missing on cross joins, and union with null fields" (#12729) #12974
+62
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
changed the title
alamb
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Thank you @matthewmturner -- I updated the title of this PR to be a bit more descriptive when it shows up in the release notes
|
FYI @wiedld |
|
For the CI failures, we may need to backport some of this PR as well (for the arrow upgrade): #12724 I will give it a go |
|
I backported the fixes for CI: #12977 close/reopen to trigger CI on this PR |
|
i am looking into the CI failure |
|
I see a test passing now (there were none last time) so i think this should be good now 🤞 |
|
Thanks agian @matthewmturner |
|
(btw I found using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #12813 . Applies fixes from #12729 to DataFusion version 42
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?