feat: Add regexp_count function #12970
Merged
+1,382
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v/xinli/regexp_count # Conflicts: # datafusion/functions/benches/regx.rs # docs/source/user-guide/sql/scalar_functions.md
…re/regexp_count # Conflicts: # datafusion/functions/src/regex/regexpcount.rs
# Conflicts: # datafusion/functions/src/regex/mod.rs # docs/source/user-guide/sql/scalar_functions.md
github-actions
bot
added
documentation
|
Note this PR does not resolve the performance degradation seen in this function as compared to regexp_match or regexp_like. (see #12080 (comment) for a benchmark) I believe that should be looked at in a followup ticket. |
|
FYI @xinlifoobar |
This was referenced Oct 18, 2024
Filed #13011 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12079 and part of #11946. Followup to PR #12080 by #xinlifoobar with some additional work (documentation, minor fixes, scalar test fixes).
Rationale for this change
Add an additional useful regexp function to datafusion
What changes are included in this PR?
Code, tests, documentation.
Are these changes tested?
Yes.
Are there any user-facing changes?
Docs updated to include the new udf.