-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(logical-types): add NativeType and LogicalType #12853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
3827974
17a70d8
3dba963
4217970
01f0089
5b5f4c1
88e1b3c
ab16a2d
0b2ed2d
6150ea9
7ed7891
bdd0155
056a8f1
117f23b
e0923e2
f1ff963
7942f91
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| use core::fmt; | ||
| use std::{cmp::Ordering, hash::Hash, sync::Arc}; | ||
|
|
||
| use super::NativeType; | ||
|
|
||
| #[derive(Debug, Clone, PartialEq, Eq, Hash, PartialOrd, Ord)] | ||
| pub enum TypeSignature<'a> { | ||
| /// Represents a built-in native type. | ||
| Native(&'a NativeType), | ||
| /// Represents an arrow-compatible extension type. | ||
| /// (<https://arrow.apache.org/docs/format/Columnar.html#extension-types>) | ||
| /// | ||
| /// The `name` should contain the same value as 'ARROW:extension:name'. | ||
| Extension { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe we can add the comment why the extension is needed?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is because arrow has extension type too.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Got there is a link to extension Arrow types above, it should be enough |
||
| name: &'a str, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be owned String, so that
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TypeSignature uses lifetimes just to make pattern matching easier when dealing with parameters (or lack thereof). pub fn important_stuff(logical_type: &dyn LogicalType) {
match logical_type.signature() {
TypeSignature::Native(NativeType::Utf8) => todo!(),
TypeSignature::Extension {
name: "JSON", // <-- changing from &'a str to String leads to: expected `String`, but found `&str`,
parameters: &[]
} => todo!(),
_ => unimplemented!()
}
} |
||
| parameters: &'a [TypeParameter<'a>], | ||
| }, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone, PartialEq, Eq, Hash, PartialOrd, Ord)] | ||
| pub enum TypeParameter<'a> { | ||
| Type(TypeSignature<'a>), | ||
| Number(i128), | ||
| } | ||
|
Comment on lines
+39
to
+43
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As someone unfamiliar with the entire discussion of this feature, it's not clear to me from reading the above link to the extension-types of arrow how these type parameters map to the metadata described in the link.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ideally everything could be encoded in the name using |
||
|
|
||
| /// A reference counted [`LogicalType`] | ||
| pub type LogicalTypeRef = Arc<dyn LogicalType>; | ||
jayzhan211 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| pub trait LogicalType: Sync + Send { | ||
| fn native(&self) -> &NativeType; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I previously propose How can we do the equivalent check by the current design?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Given say arrow Int64 data, i want to know whether these is numbers, timestamp, time, date or something else (eg user-defined enum). The fact that any of these hypothetical logical types could be stored as Int64 doesn't help me know. Asking logical type "could you please decode this arrow type?" doesn't help me know.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the idea is that we have LogicalType already. In logical level, they are either LogicalNumber, LogicalTimestamp or LogicalDate, and we can differ them in logical level. They can also decode as i64, i32 in physical level. So asking logical type "could you please decode this arrow type?" is to tell the relationship between logical type and physical type. We don't need to know whether the arrow i64 is number or timestamp, because we already know that.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure I can follow. @jayzhan211 -- can you write a small practical example? I want to make sure I understand the use case. Thanks :)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
We can figure this out if we meet any practical usage.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For any user defined logical type you still know the backing |
||
| fn signature(&self) -> TypeSignature<'_>; | ||
| } | ||
|
|
||
| impl fmt::Debug for dyn LogicalType { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| f.debug_tuple("LogicalType") | ||
| .field(&self.signature()) | ||
| .field(&self.native()) | ||
| .finish() | ||
| } | ||
| } | ||
|
|
||
| impl PartialEq for dyn LogicalType { | ||
| fn eq(&self, other: &Self) -> bool { | ||
| self.native().eq(other.native()) && self.signature().eq(&other.signature()) | ||
| } | ||
| } | ||
|
|
||
| impl Eq for dyn LogicalType {} | ||
|
|
||
| impl PartialOrd for dyn LogicalType { | ||
| fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | ||
| Some(self.cmp(other)) | ||
| } | ||
| } | ||
|
|
||
| impl Ord for dyn LogicalType { | ||
notfilippo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| fn cmp(&self, other: &Self) -> Ordering { | ||
| self.signature() | ||
| .cmp(&other.signature()) | ||
| .then(self.native().cmp(other.native())) | ||
| } | ||
| } | ||
|
|
||
| impl Hash for dyn LogicalType { | ||
| fn hash<H: std::hash::Hasher>(&self, state: &mut H) { | ||
| self.signature().hash(state); | ||
| self.native().hash(state); | ||
| } | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod test { | ||
| #![allow(dead_code)] | ||
|
|
||
| use super::{LogicalType, TypeParameter, TypeSignature}; | ||
| use crate::types::NativeType; | ||
|
|
||
| struct MagicalType {} | ||
|
|
||
| impl LogicalType for MagicalType { | ||
| fn native(&self) -> &NativeType { | ||
| &NativeType::Utf8 | ||
| } | ||
|
|
||
| fn signature(&self) -> TypeSignature<'_> { | ||
| TypeSignature::Extension { | ||
| name: "MagicalType", | ||
| parameters: &[TypeParameter::Type(TypeSignature::Native( | ||
| &NativeType::Boolean, | ||
| ))], | ||
| } | ||
| } | ||
| } | ||
|
|
||
| fn test(logical_type: &dyn LogicalType) { | ||
| match logical_type.signature() { | ||
| TypeSignature::Extension { | ||
| name: "MagicalType", | ||
| parameters: | ||
| [TypeParameter::Type(TypeSignature::Native(NativeType::Boolean))], | ||
| } => {} | ||
| TypeSignature::Native(NativeType::Binary) => todo!(), | ||
| _ => unimplemented!(), | ||
| }; | ||
| } | ||
notfilippo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| mod logical; | ||
| mod native; | ||
|
|
||
| pub use logical::*; | ||
| pub use native::*; |
Uh oh!
There was an error while loading. Please reload this page.