Fix: approx_percentile_cont_with_weight Panic #12823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgao
reviewed
Oct 9, 2024
jonahgao
reviewed
Oct 9, 2024
findepi
reviewed
Oct 9, 2024
| let mut min = cast_scalar_f64!(&state[4]); | ||
|
|
||
| assert!(max.total_cmp(&min).is_ge()); | ||
| if !min.is_finite() { |
Member
There was a problem hiding this comment.
Would it be reasonable to filter out NaN values in merge_sorted_f64 / merge_unsorted_f64 functions?
Contributor
Author
alamb
approved these changes
Oct 9, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @jonathanc-n and @findepi -- looks very nice to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12716.
Rationale for this change
Handles case where min/max are infinite or not a number (NaN)
What changes are included in this PR?
Checks if min/max values are infinite or NaN + tests
Are these changes tested?
Yes
Are there any user-facing changes?