Improve SQLite subquery tables aliasing unparsing #12482
Merged
+65
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrebnov
force-pushed
the
sgrebnov/improve-sqlite-subquery-unparsing
branch
from
60f3169
to
1146677
Compare
demetribu
reviewed
Sep 16, 2024
alamb
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Thank you @sgrebnov and @phillipleblanc and @dmitrybugakov for the review -- I took a cursor look at this PR and it looks great!
phillipleblanc
deleted the
sgrebnov/improve-sqlite-subquery-unparsing
branch
phillipleblanc
pushed a commit
to spiceai/datafusion
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow up PR for #12331 that improves SQLite subquery tables aliasing unparsing to support more complex cases, for example
What changes are included in this PR?
PRs modifies
LogicalPlan::SubqueryAlias(plan_alias)unparser to support more complex table aliasing scenarios for SQLite:1 - calculated columns
2- cases where subquery projection is wrapped by other operators (e.g., LIMIT, SORT)
Are these changes tested?
Tested manually and added unit tests
Are there any user-facing changes?
No